[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21329 [Core Tor/Tor]: onions/detached and onions/current should return empty lists instead of errors

#21329: onions/detached and onions/current should return empty lists instead of
errors
--------------------------+------------------------------------
 Reporter:  meejah        |          Owner:
     Type:  defect        |         Status:  reopened
 Priority:  Medium        |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.9
 Severity:  Normal        |     Resolution:
 Keywords:  controller    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by atagar):

 Ok, took a quick peek. Change is the following...

 {{{
 Before:

 >>> GETINFO onions/current
 551 No onion services of the specified type.
 }}}

 {{{
 After:

 >>> GETINFO onions/current
 250-onions/current=
 250 OK
 }}}

 Both responses are valid according to the spec and it doesn't specify
 what's done when no hidden services exist. Stem specifically looks for the
 old 551 response, hence the discrepancy.

 https://gitweb.torproject.org/stem.git/tree/stem/control.py#n2732

 I wouldn't mind changing stem to recognize the new behavior **but** this
 tor change may break folks who presently call
 list_ephemeral_hidden_services(). So it's a tradeoff - is this behavior
 change worth that breakage.

 Up to you, Nick.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21329#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs