[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16513 [Metrics/Onionoo]: Make writing of the out/ directory from the status/ directory deterministic

#16513: Make writing of the out/ directory from the status/ directory deterministic
-----------------------------+-------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  enhancement      |         Status:  merge_ready
 Priority:  Very High        |      Milestone:  Onionoo-2.0.0
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  iwakeh           |        Sponsor:
-----------------------------+-------------------------------
Changes (by iwakeh):

 * status:  accepted => merge_ready


Comment:

 The made changes look ok, although the new graph history compiler code is
 still not making much use the java.time classes.  But, changing it raises
 some questions about the calculations and would take too long for this
 ticket.  Thus, making a note later on the java8 ticket for Onionoo.

 The changes here and the upcoming changes in 25002 will make Onionooo
 distances independent of their local state as far as possible.

 The change here leads to identical 'out' directories when run with the
 same 'status' directory contents.  I have a few
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git/log/?h=task-16513-2
 minor unrelated commits].

 Comparing the 'out' dir resulting from Onionoo-4.4-1.8.0 with the
 resulting 'out' from the new 5.0-1.9.0  can only be done manually.  So
 far, I think those differences are due to the changes here and thus
 intended, but that's hard to verify.  Maybe, make a copy of 'out' and
 'status' before deployment to have a rollback option in the unlikely case
 there are unwanted differences?

 In total: merge ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16513#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs