[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25122 [Core Tor/Tor]: geoip: Hook the client geoip cache into the OOM handler

#25122: geoip: Hook the client geoip cache into the OOM handler
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, tor-oom, tor-dos,         |  Actual Points:
  029-backport, 031-backport, 032-backport       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 I'm guessing that clientmap_entry_size() is something we'd extend once we
 have this and #24902 merged to the same branch?

 The geoip_client_cache_total_allocation() function needs to be much faster
 -- otherwise it will eat tons of CPU by walking the whole map every time
 cell_queues_check_size() is called -- and it is called from inside
 append_cell_to_circuit_queue().  How about having a static size_t that we
 increment when we allocate an entry, and decrement when we free it?

 Otherwise, looks plausible.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25122#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs