[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23873 [Core Tor/Tor]: Remove the return value of node_get_prim_orport()

#23873: Remove the return value of node_get_prim_orport()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  enhancement     |         Status:  merge_ready
 Priority:  Medium          |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #24403          |         Points:  1
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => merge_ready


Comment:

 Thanks, neel!  This patch looks correct to me.  Let's take it early in the
 0.3.4.x series.

 The only change that I would suggest is that the function documentation
 should say that callers should check whether the result is valid before
 using it.  Either you can make that change, or I'll do it when I merge;
 either way is fine with me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23873#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs