[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25185 [Core Tor/Tor]: Create utilities for using Rust static strings in C
#25185: Create utilities for using Rust static strings in C
-----------------------------------+------------------------------------
Reporter: isis | Owner: isis
Type: enhancement | Status: merge_ready
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust, review-group-32 | Actual Points:
Parent ID: | Points: 1
Reviewer: catalyst | Sponsor: SponsorM
-----------------------------------+------------------------------------
Changes (by catalyst):
* status: needs_review => merge_ready
Comment:
I think this looks good, though I might be missing subtle things because
I'm still rather new to Rust.
Minor documentation clarity nits:
* The "Note" in the documentation for `cstr!` refers to "the above code
compiles", but it actually means the first out of three examples rather
than the example immediately preceding it. Maybe replace it with "the
first example above compiles"?
* In that same "Note", "symbols table" should probably be "symbol table"
(unless it's idiomatic in Rust documentation to use plural "symbols"
there)
These are fairly minor so feel free to merge as is or without further
review after fixing the nits.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25185#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs