[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25258 [Metrics/Website]: Include Relay Search in metrics-web

#25258: Include Relay Search in metrics-web
-----------------------------+--------------------------------
 Reporter:  irl              |          Owner:  irl
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #23518           |         Points:
 Reviewer:  karsten          |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 irl]:
 > Please review my branches [[https://gitweb.torproject.org/user/irl
 /metrics-web.git/log/?h=task/25258|task/25258]] for metrics-web

 Looks good!

 > and
 [[https://gitweb.torproject.org/user/irl/atlas.git/log/?h=task/25258|task/25258]]
 for Relay Search.

 Looks good, as far as I can tell.

 > This includes the changes from #25255 but does not include the changes
 for #25254 (so tooltips on SVGs will not be in the correct place
 currently).

 Including #25255 here sounds good. #25254 is merged by now.

 > Before merging to metrics-web the Relay Search branch should be merged
 and then the submodule in metrics-web updated to point to the primary
 repository, not my personal repository.

 Do you want to rebase your metrics-web branch to current master and change
 the submodule definition to point to the official repository? I can hold
 off pushing anything to metrics-web master for, say, 24 hours. Setting to
 needs_revision for these small changes only.

 > Relay Search is available at:
 >
 >     http://localhost:8080/rs.html

 I didn't test it now, but the commits reads fine. I'll just assume you
 tested it, and if anything comes up after merging/deploying, we can fix
 that quickly.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25258#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs