[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25260 [Applications/Tor Launcher]: Merge mozbuild files into tor-launcher.git
#25260: Merge mozbuild files into tor-launcher.git
---------------------------------------+-----------------------
Reporter: sysrqb | Owner: brade
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #24856 | Points:
Reviewer: | Sponsor:
---------------------------------------+-----------------------
Comment (by sysrqb):
After talking with Arthur about this, we decided it was worthwhile
investigating if we can include the tor-launcher extension as an isolated
file, while with the above branch, the extension is built into the browser
omni.ja. If we continue building and distributing tor-launcher as an
separate component within the installation directory, this allows for
easier updating (if it is ever needed). Specifically, the Mozilla provides
a capability of including "features" within the tree and these are loaded
as system addons (see toolkit/mozapps/extensions/docs/SystemAddons.rst for
more details).
As it turns out, this is extremely easy. In fact, it seems we don't need
to patch tor-launcher or firefox for this. Instead of copying tor-launcher
into the profile extensions directory, we can copy it directly into
browser/features/ (currently there is only e10srollout extension there). I
tested this on a fresh tor browser build on Linux. It'd be good if someone
can confirm this on OS X and Windows, as well. I also tested this on
Android and it works (in so far as Orfox loads and TorLauncher renders a
popup saying it can't execute the tor process).
Replying to [comment:3 sukhbir]:
> Do we know if this preference will be enough to continue supporting
legacy add-ons (Firefox 58 seems to be using it) or are further
architectural changes required?
I haven't looked at setting `extensions.legacy.exceptions` closely, but
after a quick look at [[https://dxr.mozilla.org/mozilla-
central/search?q=legacy.exception&redirect=false|m-c]]
it looks like this may work, but we'll need two pieces: append the
extensions in the list of `extensions.legacy.exceptions` and enable
`extensions.legacy.enabled`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs