[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25055 [Core Tor/Tor]: string_is_valid_hostname() returns true for IPv4 addresses

#25055: string_is_valid_hostname() returns true for IPv4 addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  IPv6 IPv4 tor-dns 032-backport       |  Actual Points:
  must-033                                       |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:  IPv6 IPv4 tor-dns => IPv6 IPv4 tor-dns 032-backport must-033
 * version:   => Tor: 0.3.2.1-alpha
 * milestone:  Tor: 0.3.4.x-final => Tor: 0.3.3.x-final


Comment:

 The code looks good.

 Please keep the unit tests from the two commits you reverted.
 Punycode should pass, as should partially numeric TLDs.
 You can add a test for a fully numeric TLD if you'd like, too.

 Once you've cleaned up the branch and added the unit tests, please flip
 this ticket into merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25055#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs