[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

#25013: Move TorButton code to the tor browser repository
--------------------------------------+--------------------------------
 Reporter:  igt0                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201802      |  Actual Points:
Parent ID:  #24855                    |         Points:
 Reviewer:  gk, sysrqb, mcs,          |        Sponsor:
--------------------------------------+--------------------------------
Changes (by gk):

 * keywords:  TorBrowserTeam201802R => TorBrowserTeam201802
 * status:  needs_information => needs_revision


Comment:

 Replying to [comment:17 arthuredelstein]:
 > Replying to [comment:16 igt0]:
 > > The idea is deprecate the tor button repository(we should keep it just
 for historical reasons) and move the whole tor button development to tor-
 browser.
 >
 > This was my original thinking as well, but sysrqb's investigations in
 #25260 make me wonder if we wouldn't be better off finding a way to keep
 separate repositories for torbutton and tor-launcher. Perhaps we can find
 a way to either make them system addons ("feature" XPIs), or internal JS
 modules that are copied into the tor-browser.git tree at build time.
 >
 > The advantage of maintaining separate torbutton and tor-launcher
 repositories is that we retain commit history (including the history we
 will accumulate for future commits). The tor-browser.git repository
 specifically is not so good for retaining history because we are
 constantly rebasing the patches to new versions of Firefox.

 +1 to that.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs