[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16849 [Core Tor/Tor]: clear_status_flags_on_sybil might want to clear more flags

#16849: clear_status_flags_on_sybil might want to clear more flags
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  ffmancera
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, SponsorS-deferred, technical-  |  Actual Points:
  debt, tor-dirauth, pending-disaster, review-   |
  group-32                                       |
Parent ID:                                       |         Points:  small
 Reviewer:  teor, nickm                          |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by ffmancera):

 As teor and I discussed at #tor-dev, doing the zero-and-copy approach will
 avoid new similar issues in the future with new flags, but we need to find
 out a way to check out in a unit test that we are not clearing other
 important struct fields.

 Also, there is no new flags added to the routerstatus_t struct.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16849#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs