[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6236 [Core Tor/Tor]: Remove duplicate code between parse_{c, s}method_line
#6236: Remove duplicate code between parse_{c,s}method_line
-------------------------------------------------+-------------------------
Reporter: asn | Owner: (none)
Type: task | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-client easy refactor duplicate- | Actual Points:
code |
Parent ID: | Points: 1
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by asn):
Replying to [comment:16 fristonio]:
> Thanks a lot, those strcmp's were looking a real pain when I was writing
them. It was a valuable suggestion from your side. :)
>
> I have updated the branch with the changes you asked, can you have
another look https://github.com/fristonio/tor/tree/ticket-6236.
Hello, that looks good.
I also pushed a squash commit in branch `ticket-6236` in my repo:
https://gitweb.torproject.org/user/asn/tor.git
Please check it out, and if you like it, squash it into your branch (so
that the final branch only has one commit) and push it out. Then mark this
ticket as `merge_ready`.
Thanks! And props for writing a changes file :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6236#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs