[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23046 [Metrics/Library]: Add sub-interface LogDescriptor.LogLine (and the extension to WebServerAccessLogLine)

#23046: Add sub-interface LogDescriptor.LogLine (and the extension to
WebServerAccessLogLine)
-----------------------------+-----------------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  metrics-lib 2.2.0
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  karsten          |        Sponsor:
-----------------------------+-----------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:18 iwakeh]:
 > Please review [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/commit/?h=task-23046-list2stream one commit] (branch based on
 master).

 Two issues:
  - This patch has the same issue with `count` not being reset as #25317.
  - The Javadocs for new parts in `LogDescriptor` are missing the `@since
 2.2.0` part. Also, the `Line` interface doesn't have a Javadoc comment at
 all.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23046#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs