[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25306 [Core Tor/Tor]: tor_assertion_failed_(): Bug: ../src/or/hs_service.c:1985: rotate_all_descriptors: Assertion service->desc_current failed; aborting.
#25306: tor_assertion_failed_(): Bug: ../src/or/hs_service.c:1985:
rotate_all_descriptors: Assertion service->desc_current failed; aborting.
------------------------------------------------+--------------------------
Reporter: cypherpunks | Owner: dgoulet
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.3.3.2-alpha
Severity: Normal | Resolution:
Keywords: tor-hs crash 033-must 032-backport | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------------------------+--------------------------
Changes (by asn):
* status: needs_review => needs_revision
Comment:
Two last things:
- Does the code that we added in this ticket allow the service to recover
from this issue where it has no descriptors? That is, will it ever rebuild
the needed descriptors and rotate them gracefully, or will it get
permanently stuck in a broken state? My understanding from reading the
code a bit is that the latter case will happen. Do we care about the
latter if it happens?
- In `rotate_all_descriptors()` let's add the `BUG` check inside
`should_rotate_descriptors()`. I think that's conceptually the right place
to do any check wrt rotating descriptors.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25306#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs