Re: [tor-bugs] #24767 [Core Tor/Tor]: All relays are constantly connecting to down relays and failing over and over

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#24767: All relays are constantly connecting to down relays and failing over and
over
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, tor-dos, performance,     |  Actual Points:
  review-group-32, 033-must                      |
Parent ID:                                       |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 This branch doesn't compile on macOS using clang:
 {{{
   CC       src/or/connection_or.o
 src/or/connection_or.c:1180:23: error: implicit conversion loses integer
       precision: 'uint64_t' (aka 'unsigned long long') to 'unsigned int'
       [-Werror,-Wshorten-64-to-32]
   unsigned int hash = tor_addr_hash(&entry->addr);
                ~~~~   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
 src/or/connection_or.c:1187:67: error: extra ';' outside of a function
       [-Werror,-Wextra-semi]
              or_connect_failure_ht_hash, or_connect_failure_ht_eq);
                                                                   ^
 src/or/connection_or.c:1191:48: error: extra ';' outside of a function
       [-Werror,-Wextra-semi]
              0.6, tor_reallocarray_, tor_free_);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24767#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs