[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24659 [Core Tor/Tor]: Wrap our sha2 interface in Rust which implements the appropriate traits
#24659: Wrap our sha2 interface in Rust which implements the appropriate traits
-------------------------------+------------------------------------
Reporter: isis | Owner: (none)
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust, tor-crypto, | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor: Sponsor3-can
-------------------------------+------------------------------------
Comment (by isis):
I took a stab at this some more in
[https://github.com/isislovecruft/tor/commit/fad354aa8c10c20e1ec2f98effd5edf8e43c3a51
this commit] but I'm still failing to get linking to happen for tests.
I took a break from this for a bit to work on other stuff, but I'm
beginning to agree with
[https://trac.torproject.org/projects/tor/ticket/23881#comment:8 the thing
that Chelsea said] in #23881 with the Rust logging stuff, about "The
approach of 'write C integration tests and test Rust in isolation' is an
approach taken by Servo." If I remove my tests for the correctness of the
SHA-2 implementation here, and test only in C (which I'm not actually sure
if we're doing yet?) then it'll link fine. The caveat though, which is
quite steep, would be that ''anything'' that wished to test its Rust code
and simultaneously use hashes in a non-generic way would be unable to do
so. :/
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24659#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs