[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

#23136: moat integration (fetch bridges for the user)
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:  brade
     Type:  defect                          |         Status:  needs_review
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Launcher       |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201802R, ux-team  |  Actual Points:
Parent ID:  #24689                          |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor4
--------------------------------------------+------------------------------

Comment (by gk):

 Here comes another round:

 11) "We allow response.data to be an array or object". What about
 `response.errors`?

 12) Spec says 'error', yet we check for `response.errors`, typo?

 13) braces mix

       if (!response.data)
       {
       ...
       }
       else if

 14)  // Returns a promise that is fulfilled with an object that contains:
      // captchaImage

 Do you mean "image" here instead of "captchaImage"? I looked at the spec
 and thought this was another instance of the spec you linked to being
 outdated but then I saw `image` in `_parseFetchResponse()`. If so, could
 you order the attributes in the comment lines: `transport`, `image`, and
 `challenge` as outlined in the spec?

 15)

 {{{
      * If there is no overlap between the type of bridge we requested and
      * the transports which BridgeDB supports, the response is the same
 except
      * the transport property will contain an array of supported
 transports:
      *     ...
      *     "transport": [ "TRANSPORT", "TRANSPORT", ... ],
 }}}

 Really? The spec seems to say

 {{{
 {
   'data': {
     'version': '0.1.0',
     'type': 'moat server supported transports',
     'supported': [ 'TRANSPORT', 'TRANSPORT', ... ],
   }
 }
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23136#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs