[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository
#25013: Move TorButton code to the tor browser repository
--------------------------------------+------------------------------
Reporter: igt0 | Owner: tbb-team
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201802 | Actual Points:
Parent ID: #24855 | Points:
Reviewer: gk, sysrqb, mcs, | Sponsor:
--------------------------------------+------------------------------
Changes (by igt0):
* status: needs_revision => needs_review
Comment:
I followed the same approach in the #25260, torbutton will work as a
feature extension, so we still need to change the browser adding it as a
subdirectory(git submodule?).
The changes in the tor button are related to the build system and making
it work with the mozilla central code base(few things changed and others
are deprecated).
**bug 25013: Add Gecko build system infrastructure into tor button**
https://github.com/igortoliveira/torbutton/commit/ef153a43363ee0714f6187b545494161bea96610
**bug 25013: Migrate general.useragent.locale to intl.locale.requested **
https://github.com/igortoliveira/torbutton/commit/40682676e33570d464534adc07bf94acb36a76fe
**bug 25013: Update deprecated JS code**
https://github.com/igortoliveira/torbutton/commit/1b50773f87465643ab8aed8104fa0c9a0fa5e0f5
**bug 25013: Update XPCOM calls after changes in the interfaces**
https://github.com/igortoliveira/torbutton/commit/a35a746ca206706f4c5742d70bc90b649c1bfdf0
Replying to [comment:19 gk]:
> FWIW: I can see us copying over files from the Torbutton repo or just
package up an .xpi and put the extracted files into tor-browser.git before
we tag (and use the machinery developed in some of the patches above). I
just think that step 1 of the migration should not contain getting rid of
the Torbutton repo. We should do this once we integrate the components we
need tighter into the browser. I guess this would be a thing, at some
point, for step 3 in Arthur's staged approach.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs