[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28885 [Applications/Tor Browser]: notify users that update is downloading

#28885: notify users that update is downloading
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, TorBrowserTeam201902, tbb-  |  Actual Points:
  update                                         |
Parent ID:  #25694                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  ux-team, TorBrowserTeam201902R, tbb-update => ux-team,
     TorBrowserTeam201902, tbb-update
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 mcs]:
 > An updated patch is available here:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug28885-02&id=2a43d0676e0b1c39e8620bf0697ca9c2d5247ded
 >
 > The bug28885-02 branch also contains a fix for #29180 since we tested
 these fixes together.

 Thanks, this looks good to me. Just a final nit (sorry for not mentioning
 that one earlier). Please avoid mixing bracing and non-bracing style
 within loops etc.:
 {{{
 +      for (let i = 0; i < elements.length; ++i) {
 +        let elem = elements.item(i);
 +        if (elem.hasAttribute(attrName))
 +          elem.setAttribute(attrName, label);
 +      }
 }}}
 Just braces around the if-clause and we are good to go.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28885#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs