[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29333 [Core Tor/Stem]: Use the bandwidth-file-spec.txt keywords as BandwidthFile attributes

#29333: Use the bandwidth-file-spec.txt keywords as BandwidthFile attributes
---------------------------+------------------------
 Reporter:  juga           |          Owner:  atagar
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:
Component:  Core Tor/Stem  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  tor-bwauth     |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------

Comment (by juga):

 Replying to [comment:1 atagar]:
 [...]
 > That said, I'd be happy to defer to whatever you'd like when it comes to
 BandwidthFiles. To be clear you want the following changes...
 >
 > {{{
 > * Rename desc.created_at to desc.file_created
 > * Rename desc.generated_at to desc.generator_started
 > * Rename desc.consensus_size to desc.number_consensus_relays
 > * Rename desc.eligible_count to desc.number_eligible_relays
 > * Rename desc.eligible_percent to desc.percent_eligible_relays
 > * Rename desc.min_count to desc.minimum_number_eligible_relays
 > * Rename desc.min_percent to desc.minimum_percent_eligible_relays
 > * Rename desc.measurements to desc.bandwidth_lines
 > }}}
 >
 > Is this correct?

 Yes, it's.
 However, you're right that the names you chose might be clearer.
 We have a ticket to try to decide better names for keyword #28099, and
 before April we might add other keywords as part of #28547 (see
 https://pad.riseup.net/p/sbws-exclude-reasons-keep for the keywords
 proposed so far).
 So, i'd propose that we delay these changes until we solve #28547, and
 mark this as needs_information. Sounds good?

 > On a side note I like the spec, but felt while implementing it there's a
 few rough edges...
 >
 [...]

 If we change the keywords or add new, we should change also the
 specification.
 Feel free to open tickets for the specification regarding software
 versions and not specification versions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29333#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs