[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29145 [Core Tor/Tor]: Fix a compiler warning on OpenBSD in test-memwipe.c

#29145: Fix a compiler warning on OpenBSD in test-memwipe.c
--------------------------+------------------------------------
 Reporter:  kjak          |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  041-proposed  |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:  ahf           |        Sponsor:
--------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 LGTM. For the merger: I had to look up why this symbol needs global
 linkage instead of just static linkage. You can see the documentation for
 these flags at https://man.openbsd.org/malloc#MALLOC_OPTIONS

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29145#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs