[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29018 [Core Tor/Tor]: Make all statistics depend on ExtraInfoStatistics

#29018: Make all statistics depend on ExtraInfoStatistics
------------------------------------+------------------------------------
 Reporter:  teor                    |          Owner:  teor
     Type:  enhancement             |         Status:  needs_review
 Priority:  Medium                  |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  fast-fix, security-low  |  Actual Points:  2
Parent ID:                          |         Points:  0.1
 Reviewer:  nickm                   |        Sponsor:  SponsorV-can
------------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_revision => needs_review
 * actualpoints:  0.1 => 2


Comment:

 === Branch ===

 I tried to merge the changes from 0.3.3 forward to master, but the merge
 was really complicated.

 So I opened a new pull request https://github.com/torproject/tor/pull/709
 It contains the:
 * merged changes from #29017
   * based on 0.3.3, to keep the same commit as #29017
 * rebased refactor from #29017
   * because the merge was complex
 * rebased commits from this ticket (
 https://github.com/torproject/tor/pull/639 )
   * because the merge was complex
 * new unit tests for #29017 and #29018

 === Tests ===

 The code passes `make test-network-all` with `ExtraInfoStatistics 1` and
 `ExtraInfoStatistics 0` set in chutney's common.i.

 I discovered some bugs on my local machine while writing this code.
 I don't know if they'll affect CI:
 *  #29529 util/map_anon_nofork test fails on macOS
 *  #29527 Division by zero: undefined behaviour in
 circuitpadding/circuitpadding_sample_distribution test
 *  #29530 Some address/get_if_addrs* tests fail when the network is
 unreachable

 === TODO ===

 I think there might be some memory leaks in the new unit tests, I'm not
 sure if I caught them all. I'll check in the morning once CI has finished.

 I think the coverage should have increased a bit compared with #29017 and
 master. But I'll need to wait for CI to make sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29018#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs