[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29018 [Core Tor/Tor]: Make all statistics depend on ExtraInfoStatistics

#29018: Make all statistics depend on ExtraInfoStatistics
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  fast-fix, security-low,              |  Actual Points:  2
  040-deferred-20190220, privcount               |
Parent ID:                                       |         Points:  0.1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------

Comment (by teor):

 The coveralls bot is back:
 https://github.com/torproject/tor/pull/709#issuecomment-465408842

 These unit tests increase the overall coverage by 0.2%.

 I looked at the uncovered lines: many of them are error cases or mocking.
 Some of them are from other pull requests.

 I decided not to unit test the new
 `router_build_fresh_unsigned_routerinfo()` function: it requires too much
 state. (See #29521.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29018#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs