[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29537 [Core Tor/Tor]: verify intptr_t round-trip through void *

#29537: verify intptr_t round-trip through void *
----------------------------------------+----------------------------------
 Reporter:  catalyst                    |          Owner:  (none)
     Type:  defect                      |         Status:  needs_revision
 Priority:  Medium                      |      Milestone:  Tor:
                                        |  0.4.1.x-final
Component:  Core Tor/Tor                |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  portability technical-debt  |  Actual Points:
Parent ID:                              |         Points:
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final


Comment:

 This is a good start! I'd suggest a few more things:

  * Let's not only use 42. Let's check this property for a bunch of
 suspicious values, including: 0..1024 and UINT_MAX-1024..UINT_MAX.  That
 won't catch all possible weird systems, but it will give us a few more
 chances to find corner cases.

  * Let's not put this in test.c; probably, nothing should be in test.c.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29537#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs