[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29137 [Core Tor/Tor]: Standardize 'Bandwidth File' name
#29137: Standardize 'Bandwidth File' name
--------------------------------------------+------------------------------
Reporter: atagar | Owner: (none)
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: 041-proposed, fast-fix, bwauth | Actual Points:
Parent ID: | Points: 0.1
Reviewer: teor | Sponsor:
--------------------------------------------+------------------------------
Changes (by teor):
* status: needs_review => needs_revision
Comment:
Thanks for this pull request.
Sorry it's taken me a while to get to it, I was at a hackfest, then on
leave.
Replying to [comment:2 juga]:
> Replying to [ticket:29137 atagar]:
>
> > Fix is available in the 'bandwidth_file_name' branch of my spec
repo...
> >
> >
https://gitweb.torproject.org/user/atagar/torspec.git/commit/?h=bandwidth_file_name
>
> I think it's fine except for the last 2 lines changes. Maybe create a PR
so that it can be reviewed by others?.
I opened a pull request at https://github.com/torproject/torspec/pull/57
There are 3 places where the search-and-replace is wrong.
Would you mind reverting them?
Since you made your branch, the file has been updated, so there are merge
conflicts.
Would you mind rebasing your changes on master?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29137#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs