[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28525 [Core Tor/Tor]: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large Scale NAT) IPv4 Ranges

#28525: Make tor_addr_is_internal_() aware of RFC 6598 (Carrier Grade NAT/Large
Scale NAT) IPv4 Ranges
-----------------------------------------+---------------------------------
 Reporter:  neel                         |          Owner:  neel
     Type:  enhancement                  |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  unspecified
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  ipv6, 040-deferred-20190220  |  Actual Points:
Parent ID:                               |         Points:
 Reviewer:  nickm                        |        Sponsor:
-----------------------------------------+---------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 This looks plausible to me.  I'd like to see one more commit here, though,
 documenting the new behavior of `for_listening` in the documentation
 comments.  I'd like it to explain when you should use IP_LISTEN_EXTERNAL
 and when (if ever?) you should use IP_LISTEN_INTERNAL.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28525#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs