[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable
#29120: Default value of media.cache_size (0) causes some media to load extremely
slowly or become unplayable
-------------------------------------------------+-------------------------
Reporter: QZw2aBQoPyuEVXYVlBps | Owner: tbb-
| team
Type: defect | Status:
| needs_review
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-disk-leak, tbb-usability- | Actual Points:
website, TorBrowserTeam201902R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by QZw2aBQoPyuEVXYVlBps):
Replying to [comment:28 mcs]:
>
> The patch looks good to us. We are a little concerned about portions of
comment:25, especially the part about `return nullptr;` (because we are do
not understand cyperpunks' point).
I also have no idea what cypherpunks meant by that comment. The original
Mozilla code also returns nullptr on failure, so we're not changing any
logic in that regard. It's even documented in the function comment:
https://hg.mozilla.org/releases/mozilla-
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l152
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs