[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33092 [Core Tor/Tor]: Pass -bind_at_load on macOS
#33092: Pass -bind_at_load on macOS
--------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by teor):
Replying to [comment:3 nickm]:
> What is the reason for doing this?
The original PR says that it reduces the tor binary size by about 5.5
kilobytes on macOS:
https://github.com/torproject/tor/pull/1655
However, it's a risky change if we're using weak linking on macOS or iOS
(which I don't think we do, but other tor packagers might). I think if we
try to bind all symbols at launch, and the current macOS doesn't have an
optional symbol, we'll crash at launch. (Rather than testing if the
optional symbol is NULL, or if we don't test, crashing when we use that
symbol.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33092#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs