[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2317 [Tor Client]: Missing sanity checks for cbtnummodes consensus parameter
#2317: Missing sanity checks for cbtnummodes consensus parameter
------------------------+---------------------------------------------------
Reporter: Sebastian | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.1.x-final
Component: Tor Client | Version:
Keywords: | Parent:
------------------------+---------------------------------------------------
Comment(by nickm):
On my first comment: You have an inline comment in one of the specs
asking if INT32_MAX or 2147483647 is best and if they're always equal.
They're always equal, and I think "INT32_MAX" is a better way to refer to
the value.
On the second: I'm not saying we shouldn't warn; I'm saying that it would
be much cleaner to only use networkstatus_get_param() to enforce hard
constant limits on values, and do any additional clipping and warning in
the wrapper functions.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2317#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs