[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2077 [Tor Client]: Tor crashes in Vidalia 0.2.2.17a-0.2.10

#2077: Tor crashes in Vidalia 0.2.2.17a-0.2.10
--------------------------------+-------------------------------------------
 Reporter:  joebt               |        Type:  defect    
   Status:  needs_review        |    Priority:  normal    
Milestone:  Tor: 0.2.2.x-final  |   Component:  Tor Client
  Version:                      |    Keywords:  Tor,      
   Parent:                      |  
--------------------------------+-------------------------------------------
Changes (by special):

 * cc: special@â (added)


Comment:

 I can confirm that nickm/gmtime_null, after applying the attached patch,
 stops the crash. nickm/2077_movefileex (dd7ef9ac) builds, works correctly,
 and fails correctly, but I won't be able to confirm that it solves this
 bug without running it for awhile.

 There is a small memory leak in 2077_movefileex:

 {{{
 diff --git a/src/or/routerlist.c b/src/or/routerlist.c
 index f85db08..0fa2a8f 100644
 --- a/src/or/routerlist.c
 +++ b/src/or/routerlist.c
 @@ -747,6 +747,7 @@ router_rebuild_store(int flags, desc_store_t *store)
      char *errmsg=NULL;
      if (replace_file(fname_tmp, fname, &errmsg)<0) {
        log_warn(LD_FS, "Error replacing old router store: %s", errmsg);
 +      tor_free(errmsg);
        goto done;
      }
      tor_free(errmsg);
 }}}

 That resolves everything other than arma's notes about the value of
 LastWritten. Note that with gmtime_null, LastWritten will be 1/1/1970 in
 the first successful state file after a write failure.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2077#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs