[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2346 [Tor Client]: Failing to write state file means you try every second



#2346: Failing to write state file means you try every second
------------------------+---------------------------------------------------
 Reporter:  arma        |       Owner:                    
     Type:  defect      |      Status:  needs_review      
 Priority:  normal      |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------

Comment(by arma):

 Looks good to me.

 The only slight catch is that the changelog message is misleading. We're
 setting it up to try another write in an hour, unless something changes
 before then. See or_state_mark_dirty() in or.h

 (My guess is most of the time something will change before then.)

 As for specific fixes, you could change "wait an hour" to "wait up to an
 hour" in the changes file, and change "Try again in after" (sic) to "Try
 again in at most" in the comments.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2346#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs