Re: [tor-bugs] #2374 [Development Progress]: or-cvs list doesn't send mail for merges or tags

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2374: or-cvs list doesn't send mail for merges or tags
--------------------------+-------------------------------------------------
 Reporter:  cypherpunks   |        Type:  defect              
   Status:  needs_review  |    Priority:  normal              
Milestone:                |   Component:  Development Progress
  Version:                |    Keywords:                      
   Parent:                |  
--------------------------+-------------------------------------------------

Comment(by Sebastian):

 I think -m is not what we want - it would mean huge diffs for large
 branches (that might not make it to or-cvs because they are huge), and
 more importantly it actually hides when there *is* a change (unless you
 scan the big diff carefully). I think going with the --cc option is what
 we want here, because it seems to give the best info imo.

 I'm not sure we'd want to omit empty merges tho; seems like some people
 might care that the commit added to a branch was not a fast forward and
 rather a merge. (I don't have a preference either way)

  Small typo I noticed: the script is called logs_to_emails.pl, but in the
 suggested usage section it is log_to_emails.pl

 Other then that, this looks ok to me. I didn't test actually emailing
 using formail, but the rest looks good (tested all options (-m, -c, --cc),
 empty merges, merges with conflicts, merges of merges with conflicts,
 etc).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2374#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs