[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-bugs] #2409 [Tor Client]: check_signature_token broken in merge commit ed87738ede789fb

#2409: check_signature_token broken in merge commit ed87738ede789fb
------------------------+---------------------------------------------------
 Reporter:  rransom     |       Owner:                    
     Type:  defect      |      Status:  new               
 Priority:  minor       |   Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |     Version:                    
 Keywords:              |      Parent:                    
------------------------+---------------------------------------------------
 The `check_signature_token` function (in src/or/routerparse.c) was broken
 in merge commit
 [https://gitweb.torproject.org/tor.git/commit/ed87738ede789fb
 ed87738ede789fb]: the string "`< digest_len`" was replaced with "`<
 DIGEST_LEN`" on line 1090 (see the last hunk of
 [https://gitweb.torproject.org/tor.git/blobdiff/b27f5cc50d4a66bff31e43a596eb296a1b5a11dc..ed87738ede789fb:/src/or/routerparse.c
 the diff from the first parent of that commit for src/or/routerparse.c]).

 This is currently not a problem, as the function's parameter `digest_len`
 is always equal to `DIGEST_LEN`, but we should fix it anyway.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2409>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs