[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #3457 [Tor Client]: Expose more circuit state-change events to controllers
#3457: Expose more circuit state-change events to controllers
---------------------------+------------------------------------------------
Reporter: rransom | Owner: rransom
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: small-feature | Parent:
Points: | Actualpoints:
---------------------------+------------------------------------------------
Comment(by rransom):
Replying to [comment:9 nickm]:
> notes to myself for revisions to make:
>
> * rename circuit_change_purpose to circuit_set_purpose for consistency
`circuit_change_purpose` isn't called (and shouldn't be) the first time a
circuit's purpose is set.
> * Use smartlist_add_asprintf() in
circuit_describe_status_for_controller
> * Come up with a better name for circ2 if possible
> * nuke the explicit enumeration-value setting in
circuit_status_2_event_t
> * For formatting time, "sec,usec" is pretty horrible and not what we
do elsewhere in tor or in control-spec. Either ISOTime or some spaceless
variant thereupon would be better. (in
circuit_describe_status_for_controller()). If for some reason we can't
use ISOTime (or some spaceless variant etc), then let's use an actual
decimal fraction.
Torperf uses that format. I agree that it sucks, but I didn't know of any
formatting functions already in Tor that would emit all the information in
that time struct.
> * void* arg2 is making me uncomfortable. If that's only a timeval for
now, let's make it a timeval. If it really has to be lots of other things,
let's make typechecking wrapper functions as needed.
>
> rransom, do you have any suggestions for a better name for CIRC2?
`CIRC_MINOR`? `CIRC_MINOR_EVENT`?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3457#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs