Re: [tor-bugs] #3729 [Pluggable transport]: obfsproxy rate limiting

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3729: obfsproxy rate limiting
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:  #3591       
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by asn):

 Replying to [comment:5 nickm]:
 > What happens if the rate is set but the burst is not? it looks like only
 the opposite case is configured.If the rate is set but the burst is not, I
 set the burst to `EV_RATE_LIMIT_MAX`. So I end up with the user-defined
 rate, and an unlimited burst.
 >

 If the rate is set but the burst is not, I set the burst to
 `EV_RATE_LIMIT_MAX`. So I end up with the user-defined rate, and an
 unlimited burst.

 > Converting strings to integers seems like it's part of the UI, and
 should probably happen in main or something, not network.
 >

 At the moment, this is just an atoi() call inside the
 `SET_RATE_LIMITING_VALUE` macro. Do you think I should move a wrapper of
 it in `main`?

 > The SET_RATE_LIMITING_VALUE macro should probably check for overflow.
 >

 Done. Please check branch `bug3729_take2` again.

 > Otherwise looks okay.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3729#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs