[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3726 [Pluggable transport]: obfsproxy needs contrib/checkSpace.pl

#3726: obfsproxy needs contrib/checkSpace.pl
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:  #3591       
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------
Changes (by asn):

  * status:  new => needs_review


Comment:

 Please see branch `bug3726` in
 `https://git.gitorious.org/obfsproxy/obfsproxy.git`.

 I think it's a good time to introduce checkSpace.pl in obfsproxy. The code
 is stable (till #4685 stuff appear), and the only thing remaining to get
 merged is #3729.

 BTW, `5cc436a6` in branch `bug3726` is a bit crude. I would, instead,
 prefer to remove the cast to `unsigned long` (and also remove it in all
 the other similar cases in obfs2.c and network.c). How do we feel about
 C99 and its 'z' format string length specifier ("%zu" for size_t, for
 example)?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3726#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs