[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4913 [Stem]: Add stem.util.conf.Config.save()
#4913: Add stem.util.conf.Config.save()
-------------------------+--------------------------------------------------
Reporter: gsathya | Owner: atagar
Type: enhancement | Status: needs_revision
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by atagar):
* status: needs_review => needs_revision
Comment:
I've pushed a couple of your changes (6c5f020 and 451e13e) with some very
minor tweaks. Would you mind adding an integ test for your save function?
I'd be happy to help if you're unsure what to add.
> + return self._contents.keys()
I'm gonna hazard the guess that this is testing code since the save()
function is then a no-op. ;)
> def iterkeys(self):
I'm not sure of the point of this function... why did you add it? When you
call dict.keys() it's an iterable object... I suppose getting an iterator
directly is slightly more efficient but probably not worth adding a new
function.
> On the other hand, if we pass Multiple = True, we'd get a list of values
which we dont need like...
I'm not following, mind clarifying why you'd only want to save
'login.password -> ["foo"]'?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4913#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs