[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4919 [Pluggable transport]: obfsproxy: Wrong sizeof target in pending_socks_cb()

#4919: obfsproxy: Wrong sizeof target in pending_socks_cb()
------------------------------------+---------------------------------------
    Reporter:  asn                  |       Owner:  asn   
        Type:  defect               |      Status:  closed
    Priority:  normal               |   Milestone:        
   Component:  Pluggable transport  |     Version:        
  Resolution:  fixed                |    Keywords:        
      Parent:                       |      Points:        
Actualpoints:                       |  
------------------------------------+---------------------------------------
Changes (by nickm):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 This looks wrong too; it should be sizeof(ss).  sizeof(*sa) is
 sizeof(struct sockaddr), which is less than the amount of storage
 available.

 Just did the right fix in c24f24b5647e9816f2ce76e265edd6091dc7abe3 ;
 please reopen if it's wrong.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4919#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs