[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3842 [Tor Client]: Missing signal/names option



#3842: Missing signal/names option
-----------------------------+----------------------------------------------
 Reporter:  atagar           |          Owner:                    
     Type:  enhancement      |         Status:  needs_review      
 Priority:  minor            |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor Client       |        Version:                    
 Keywords:  easy controller  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by nickm):

  * milestone:  Tor: unspecified => Tor: 0.2.4.x-final


Comment:

 This looks reasonable; I like the table-driven approach.

 I wonder whether it wouldn't make sense to have the GETINFO values
 constructed from the table; I'd say "not necessarily", but if not, we
 should add a comment to the table saying that whenever we add a new value,
 we need to make certain to add it to GETINFO signal/names.  (Otherwise
 we'll forget to add new values to signal/names)

 Right now Tor 0.2.3.x is in feature-freeze, so I'm marking this for merge
 in 0.2.4.x once that branch is open.

 Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3842#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs