[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7631 [Stem]: Try a PEP8 style checker

#7631: Try a PEP8 style checker
----------------------------+-----------------------------------------------
    Reporter:  atagar       |       Owner:  atagar  
        Type:  enhancement  |      Status:  reopened
    Priority:  minor        |   Milestone:          
   Component:  Stem         |     Version:          
  Resolution:               |    Keywords:  testing 
      Parent:               |      Points:          
Actualpoints:               |  
----------------------------+-----------------------------------------------

Comment(by robinson):

 Damian,

 I recently checked out pylint, pyflakes, flake8, and pychecker (?).  None
 of them impressed me enough to want to use on any of my projects.

 I looked into configuring pep8 for Stem and I think I was too harsh
 before.  The --ignore flag does let one turn off specific error-checking.

 {{{
 pep8 --ignore=E111,E121 run_tests.py
 }}}

 I was able to disable "E111 indentation is not a multiple of four" and
 "E121 continuation line indentation is not a multiple of four" messages
 with the above command, which reduced the errors/warnings on run_tests.py
 from 295 to 120.

 {{{
 pep8-py2.7 --ignore=E111,E121,W293 run_tests.py
 }}}

 Adding a warning "W293 blank line contains whitespace" to the ignore list,
 gets down to 42 messages (mainly "E501 line too long").

 While the current coding style is not what I'm used to, it's not
 unreasonable.  It does mean you, Damian, get to clean up submissions from
 new contributors until we each figure things out.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7631#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs