[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3197 [Tor bundles/installation]: m:/tor-mingw/tbb-erinn.git/build-scripts/build-stable-windows/built/share\tor\fallback-consensus

#3197: m:/tor-mingw/tbb-erinn.git/build-scripts/build-stable-
windows/built/share\tor\fallback-consensus
--------------------------------------+-------------------------------------
 Reporter:  arma                      |          Owner:  erinn
     Type:  defect                    |         Status:  new  
 Priority:  normal                    |      Milestone:       
Component:  Tor bundles/installation  |        Version:       
 Keywords:                            |         Parent:       
   Points:                            |   Actualpoints:       
--------------------------------------+-------------------------------------

Comment(by cypherpunks):

 Replying to [comment:2 arma]:
 > Is this (probably) still an issue?

 Yes, this is still an issue.

 And this issue is not specific to TBB. It impacts all Windows Tor
 binaries, expert bundle, probably the half-dozen Vidalia bundles, as well.

 For any tor.exe you build, try this:

 strings tor.exe | grep y - erinn

 you can see this invalid hard-coded path, and some other artifacts of
 Erinn's Mac OSX build system.

 > What steps can we take in our build process (ideally automated)
 > to reduce the chance that this recurs?

 1) Document the Windows Tor build process. I mean update the old win32
 build docs, which refer to MinGW instalers that no longer exist. Plus,
 update the instructions to discuss how Erinn is cross-compiling from a Mac
 OSX box. So contributors can help you fix it, building precisely like you
 do.

 2) Ship a build log along with the resulting binary artifacts. It'll help
 with trust, and it'll help contributors who are trying to diagnose this
 problem.

 3) Perhaps also automate the above grep and fail when erinn's name is
 located, except for the GCC flags line, I presume.

 Thanks,
 Lee

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3197#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs