[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8081 [Tor]: 7802 tweaks per code review
#8081: 7802 tweaks per code review
--------------------+-------------------------------------------------------
Reporter: andrea | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
Comment(by nickm):
Merging double-0-check, the branch with a license to invoke
implementation-defined behavior.
2f71cc51fa71ca5040ef2076ac010950584b81e6 -- comments only. Looks okay!
cbb2acebb17582c1d25dfe181556e2c411bf72f9 -- yup, that looks like what I
had in mind.
e6141e47e932a9f13aae3a4a546ec37348b8ce35 -- all the new places look
correct; assuming none were missed, this is cool.
f2e40c7b625c26be0edab4cf133f28d5cc09febc -- Looks correct.
12e1abf97af9632db9de2f4eb7bd717bcb222e6e -- Plausible. My inner hobgoblin-
of-little-minds doesn't like "return;" at the end of functions.
caf6fe591c0b6d0ef9b74a29c73c7468200936e1 -- seems fine.
08396c3e7abadeee569876e4291c4c1bdd3ebe6a -- looks okay
565f6a22346b45638e78c499a6dd0ef5d50caa57 -- sure.
1e5a1ae9ec1e6607832975e7290b17daf9b0f147 -- Can we get better
documentation here some time? "governs the fixed-point precision" doesn't
say *how* it governs the aforementioned fixed-point precision.
834b09e205606f573401bbe576608e2dfaba1025 -- if you say so.
0e4cfc2df966ea3be4cc11c786799231ea5d151c -- yep.
> I haven't tested it yet.
How much testing do you think we want to do here? Think I should merge,
or wait for more testing?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8081#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs