Re: [tor-bugs] #10758 [Tor]: Stop serving version 2 directory information by default

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#10758: Stop serving version 2 directory information by default
-----------------------------+--------------------------------
     Reporter:  karsten      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by karsten):

 Replying to [comment:10 nickm]:
 > Well, I'm mostly hoping for a review of all the complex pieces and
 subtle little lines there to make sure they didn't do something crucial
 that wasn't related to the v2 networkstatus system.
 >
 > Here are some examples:
 >    * v2_ns_dl_status didn't have some extra unexpected meaning, did it?
 >    * Did anything bad just happen to routerlist_remove_old_routers?
 >
 > I think the answers are "no", but that was some complex logic I just
 chopped out.

 I just took another look at the two examples and once more at the entire
 patch.  I didn't spot anything in the removed v2 code or changed functions
 that would break v3.  But obviously, that doesn't necessarily mean there
 is no such code.  A fresh pair of eyes would probably be much more
 reliable than mine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10758#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs