[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #13928 [Tor]: Tor Authorities reachability testing is predictable and sequential
#13928: Tor Authorities reachability testing is predictable and sequential
------------------------+--------------------------------
Reporter: teor | Owner: teor
Type: defect | Status: needs_revision
Priority: normal | Milestone: Tor: 0.2.6.x-final
Component: Tor | Version: Tor: 0.2.6.1-alpha
Resolution: | Keywords: tor-auth
Actual Points: | Parent ID: #14034
Points: |
------------------------+--------------------------------
Changes (by nickm):
* status: needs_review => needs_revision
Comment:
reviewing...
065bb7be0309535ae298eb99a5452b3620d4c018:
 Â* In dirserv_reachability_modulo_per_test and
dirserv_reachability_initial_group, I'm not thrilled with having this be a
uint8_t but take an int, and having most possible values of int getting
silently turned into something out of range.
* I'd prefer separate getter and setter functions; that's what we do in
most other places.
 Â*ÂMaybe "n_relay_testing_groups" or something would be a better name
than "modulo_per_test"? Modulo as a noun doesn't mean much here.
4e6789aef56e71a9ab5ba6c983ffd757147d8dd7:
* Should probably get tests to ensure that nothing is missed or double-
hit.
* This isn't exactly a random permutation. It's predictable and
observable once you see a couple of values. Would using
smartlist_shuffle() to get an actual random permutation be of any use
here? (If not, we should probably use another word besides "permutation")
*
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13928#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs