[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13111 [Tor]: Tor fails to start if onion keys are zero length

#13111: Tor fails to start if onion keys are zero length
-------------------------+--------------------------------
     Reporter:  ioerror  |      Owner:  teor
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-relay lorax
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------

Comment (by teor):

 If we can handle reading an empty file, and we merge #13111 with #9321 in
 0.2.6, this code in #9321:
 {{{
 +      if (file_status(options->GuardfractionFile) != FN_FILE) {
 +        REJECT("GuardfractionFile set but not a file? Failing");
 +      }
 +
 +      dirserv_read_guardfraction_file(options->GuardfractionFile, NULL);
 }}}

 will need to be updated to:
 {{{
 +      if (file_status(options->GuardfractionFile) != FN_FILE &&
 file_status(options->GuardfractionFile) != FN_EMPTY) {
 +        REJECT("GuardfractionFile set but not a file? Failing");
 +      }
 +
 +      dirserv_read_guardfraction_file(options->GuardfractionFile, NULL);
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13111#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs