[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13079 [Tor Browser]: environment variable to skip TorButton control port verification

#13079: environment variable to skip TorButton control port verification
-------------------------+-------------------------------------------------
     Reporter:  proper   |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-torbutton,
  Browser                |  TorBrowserTeam201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Replying to [comment:8 mcs]:
 > The patch looks OK.  The only question I have is whether we should check
 for a value of "1" in the TOR_SKIP_CONTROLPORTTEST env variable (rather
 than just checking for existence).  In Tor Launcher, we use "1" !=
 environ.get(...) tests, although I see one place in Torbutton where we
 just check for existence (search for TOR_TRANSPROXY within src/components
 /startup-observer.js to find it).

 Personally, I think having just the existence of the environment variable
 is enough. It seems a bit awkward to have an environment variable set with
 a value that indicates that you just want to have the default behavior.
 Why having the variable set in the first place at all then? If there are
 use-cases where we need to check the value because there are more than two
 possible values (or where neither of the two values is the default value
 you get by unsetting the environment variable) then this might be a
 different story, of course.

 That said I don't mean to imply that we should change the way Tor Launcher
 does this. But I'd like to keep the related Torbutton code as-is and to
 avoid mixing both styles.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13079#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs