[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12585 [Tor]: Implement new option SocksSocket

#12585: Implement new option SocksSocket
-----------------------------+--------------------------------
     Reporter:  ioerror      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  026-triaged-1
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by ioerror):

 OK, I've given it a first pass and my thought is: hooray - Andrea you're a
 really great programmer and thank you for the revision!

 I totally agree with renaming is_tcp to is_stream (
 https://gitweb.torproject.org/user/andrea/tor.git/commit/?h=ticket12585_v3&id=48633c07660216d3b852b609c44fa318d55908f0
 ) - seems very reasonable. The refactor (
 https://gitweb.torproject.org/user/andrea/tor.git/commit/?h=ticket12585_v3&id=2ca1c386b0d1c396fa8d8f4b5334349e24a2f9e8
 ) for connection_listener_new() looks reasonable and I'd like a second set
 of eyes to confirm it. The extra guard on the chmod is a nice touch,
 thanks for fixing it. The commit (
 https://gitweb.torproject.org/user/andrea/tor.git/commit/?h=ticket12585_v3&id=a3bcde3638d035303a9a5bf8373c1b841a1f5636
 ) to switch logging to info from notice seems reasonable.

 So - I'd consider this a sign-off and a request for nickm or others to
 also sign off.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12585#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs