Re: [tor-bugs] #13806 [Tor]: Count HSDir storage towards MaxMemInQueues

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13806: Count HSDir storage towards MaxMemInQueues
------------------------+-------------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay tor-hs oom security
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-------------------------------------------
Changes (by dgoulet):

 * keywords:  tor-relay, tor-hs, oom, security, nickm-patch => tor-relay
     tor-hs oom security


Comment:

 The only part I was still worried about is this one for overflow but I
 hardly see a way that it could realistically happen here unless we have
 actually X cache entries and that number times the size of a single object
 is bigger than {{{size_t}}} for which you'll do a couple more loops until
 the last served cuttoff is big enough.

 {{{
 bytes_removed += rend_cache_entry_allocation(ent);
 }}}

 So, looks good! here is my Acked-by!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13806#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs