[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7555 [Tor]: MapAddress from FQDN to .onion fails because resolve requests for hidden services are not allowed.

#7555: MapAddress from FQDN to .onion fails because  resolve requests for hidden
services are not allowed.
-------------------------+-------------------------------------------------
     Reporter:  aagbsn   |      Owner:  nickm
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-client, 025-triaged, nickm-
   Resolution:           |  patch, asn-review
Actual Points:           |  Parent ID:  #14192
       Points:           |
-------------------------+-------------------------------------------------

Comment (by rl1987):

 * The unit test in `test_entryconn_rewrite_mapaddress_automap_onion2()`
 doesn't seem to cover all subcases that might be of interest here. What is
 supposed to happed when AutomapHostsOnResolve is off? What kind of
 behaviour we expect when there is no MapAddress line(s) in torrc? When
 user decides to remove .onion from AutomapHostsSuffixes and/or add .net?
 The unit test checks for single lucky case, but does not attempt define
 and assert correct behaviour for other cases.
  * AllowDotExit has nothing to do with functionality being tested in
 aforementioned unit test.
  * `//  tt_int_op(rr.automap, OP_EQ, 1);` <-- commented out lines are
 generally poor code hygiene. Besided, this time we do care whether or not
 it did automapping.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7555#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs