[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13788 [Tor Browser]: Meek bridges don't work in TB 4.5alpha1

#13788: Meek bridges don't work in TB 4.5alpha1
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  TorBrowserTeam201501R,
  Browser                |  tbb-4.5-alpha-3, MikePerry201501R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:31 mikeperry]:
 > I also noticed that all of these patches demote the nsIProxyInfo member
 of nsSocketTransport2 from a nsCOMPtr to an unmanaged bare pointer. What
 was the reason for this change? Unless I'm missing some other far flung
 magic, I think this is a likely UAF due to the missing refcount
 management?

 You're right -- that was a mistake. Here's the new version:
 https://github.com/arthuredelstein/tor-
 browser/commit/bcbe56c40ae214449d4269de63cf9a219e5ec7df

 (Tested with meek.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13788#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs