[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9701 [Tor Browser]: Prevent TorBrowser from creating clipboardcache turds
#9701: Prevent TorBrowser from creating clipboardcache turds
-------------------------+-------------------------------------------------
Reporter: | Owner: mikeperry
cypherpunks | Status: needs_review
Type: defect | Milestone:
Priority: normal | Version:
Component: Tor | Keywords: tbb-disk-leak, interview, tbb-
Browser | firefox-patch, TorBrowserTeam201501R
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Changes (by michael):
* keywords: tbb-disk-leak, interview, tbb-firefox-patch,
TorBrowserTeam201501 => tbb-disk-leak, interview, tbb-firefox-patch,
TorBrowserTeam201501R
* status: needs_information => needs_review
Comment:
Regarding
[https://trac.torproject.org/projects/tor/attachment/ticket/9701/msvb9701-283f7c6.patch
msvb9701-283f7c6.patch], preemptive consideration of the question is:
'''Won't this break binary compatibility''' causing dependent code to
crash at runtime?
Answer: Yes, but '''only if the dependent code uses the new method ^1^'''
while calling into the old (not overloaded) vtable. Or possibly
NS_ERROR_OBJECT_IS_IMMUTABLE is returned from dependent code.
^1^ Assuming XPCOM/GCC works like classic COM/VC++.
Furthermore, the interface signature (struct DataStruct) in question has
no corresponding IDL entry, so it hopefully won't be called from foreign
(non Mozilla) components at all?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9701#comment:29>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs